Skip to content

🎨 adding folder_id to project resource #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 27, 2024
Merged

🎨 adding folder_id to project resource #6460

merged 11 commits into from
Sep 27, 2024

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 27, 2024 •
edited
Loading

What do these changes do?

  • 🎨 adding folder_id to project resource (This folder ID depends on the context of the user retrieving the project, as the user may have the shared project in their private folder.)

Related issue/s

How to test

  • both private and shared workspace project listing tested ✔️

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 27, 2024
@codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.9%. Comparing base (cafbf96) to head (db4a6ee).
Report is 595 commits behind head on master.

Files with missing lines Patch % Lines
...erver/src/simcore_service_webserver/projects/db.py 88.8% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6460      +/-   ##
=========================================
+ Coverage    84.5%   88.9%    +4.3%     
=========================================
  Files          10    1245    +1235     
  Lines         214   54624   +54410     
  Branches       25     871     +846     
=========================================
+ Hits          181   48581   +48400     
- Misses         23    5911    +5888     
- Partials       10     132     +122
Flag Coverage Δ
integrationtests 64.7% <80.5%> (?)
unittests 86.6% <97.4%> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/models_library/api_schemas_webserver/projects.py 100.0% <100.0%> (ø)
...ages/models-library/src/models_library/projects.py 92.6% <100.0%> (ø)
...e_service_webserver/projects/_access_rights_api.py 97.2% <100.0%> (ø)
...ore_service_webserver/projects/_crud_api_create.py 96.7% <100.0%> (ø)
...mcore_service_webserver/projects/_crud_handlers.py 92.0% <100.0%> (ø)
...rc/simcore_service_webserver/projects/_db_utils.py 92.3% <ø> (ø)
...r/src/simcore_service_webserver/projects/models.py 100.0% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 84.6% <100.0%> (ø)
...erver/src/simcore_service_webserver/projects/db.py 97.6% <88.8%> (ø)

... and 1221 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Sep 27, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Sep 27, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 27, 2024 09:42
odeimaiz
odeimaiz approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

GitHK
GitHK reviewed Sep 27, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I left some suggestions.

Summary of this PR: essentially you are now passing folder_id as part of the response model. correcty?

@matusdrobuliak66 matusdrobuliak66 merged commit a50d80c into ITISFoundation:master Sep 27, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the add-folder-id-to-project-resource branch September 27, 2024 15:02
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@matusdrobuliak66 @mrnicegyu11
🎨 adding folder_id to project resource (ITISFoundation#6460)
925b817
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @GitHK @pcrespov @odeimaiz